Fork Sync: Update from parent repository#176
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
The PRRTE AGENTS.md and its PMIx counterpart share the same authorship and much of the same guidance, but the PMIx file had accumulated several general, project-agnostic rules that PRRTE's copy was missing. Carrying them over keeps the two orientation guides consistent so an agent moving between the code bases meets the same expectations, and it fills real gaps in the PRRTE guidance around style, hygiene, and process. Added: the conditional-spacing style rule; a directive to update .gitignore for any build product a change introduces; the "never bend a test to accommodate a bug" testing rule; a shared-repository/worktree section warning against repo-wide git commands; the preference for C++-style comments; commit-message guidance (body line wrapping, no AI tooling attribution, incidental fixes as standalone commits); and a maintainer-mode caution for build-system edits. While porting the build-system guidance, correct an over-broad claim in the existing text: because PRRTE builds in maintainer mode, editing a Makefile.am does not require the full autogen.pl plus configure cycle — a plain make regenerates the affected Makefiles. Also repair a garbled duplicate line in the copyright-header rule. Signed-off-by: Ralph Castain <rhc@pmix.org>
The m4-configure component list for each framework is ordered from highest to lowest priority so that STOP_AT_FIRST, STOP_AT_FIRST_PRIORITY, and PRIORITY frameworks configure their components in the intended order. Until now that ordering was produced by shelling out to config/prte_mca_priority_sort.pl through esyscmd during configure, which forks an external Perl interpreter at autogen time and adds Perl as an implicit build dependency for this one small task. Do the sort entirely in m4 instead. MCA_ORDER_COMPONENT_LIST now scans the framework's components to find the highest and lowest priorities, then walks the priorities from high to low, emitting the components that carry each priority. Walking the priorities rather than sorting the components preserves the original relative order among components that share a priority, matching the previous behavior. The Perl script and its EXTRA_DIST entry are removed. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.